drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3474) Add implicit file columns support
Date Wed, 11 May 2016 05:18:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279563#comment-15279563
] 

ASF GitHub Bot commented on DRILL-3474:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/491#discussion_r62793024
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeScanBatchCreator.java
---
    @@ -67,17 +67,15 @@ public ScanBatch getBatch(FragmentContext context, HiveDrillNativeParquetSubScan
         final List<SchemaPath> columns = config.getColumns();
         final String partitionDesignator = context.getOptions()
             .getOption(ExecConstants.FILESYSTEM_PARTITION_COLUMN_LABEL).string_val;
    +    List<Map<String, String>> virtualColumns = Lists.newLinkedList();
    --- End diff --
    
    Name these implicitColumns instead of virtualColumns to keep the naming consistent? 


> Add implicit file columns support
> ---------------------------------
>
>                 Key: DRILL-3474
>                 URL: https://issues.apache.org/jira/browse/DRILL-3474
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Metadata
>    Affects Versions: 1.1.0
>            Reporter: Jim Scott
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> I could not find another ticket which talks about this ...
> The file name should be a column which can be selected or filtered when querying a directory
just like dir0, dir1 are available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message