drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3474) Add implicit file columns support
Date Wed, 11 May 2016 05:18:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279562#comment-15279562
] 

ASF GitHub Bot commented on DRILL-3474:
---------------------------------------

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/491#discussion_r62792998
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -148,6 +148,18 @@
       String FILESYSTEM_PARTITION_COLUMN_LABEL = "drill.exec.storage.file.partition.column.label";
       OptionValidator FILESYSTEM_PARTITION_COLUMN_LABEL_VALIDATOR = new StringValidator(FILESYSTEM_PARTITION_COLUMN_LABEL,
"dir");
     
    +  /**
    +   * Implicit file columns
    +   */
    +  String IMPLICIT_FILENAME_COLUMN_LABEL = "drill.exec.storage.implicit.filename.column.label";
    +  OptionValidator IMPLICIT_FILENAME_COLUMN_LABEL_VALIDATOR = new StringValidator(IMPLICIT_FILENAME_COLUMN_LABEL,
"filename");
    +  String IMPLICIT_SUFFIX_COLUMN_LABEL = "drill.exec.storage.implicit.suffix.column.label";
    +  OptionValidator IMPLICIT_SUFFIX_COLUMN_LABEL_VALIDATOR = new StringValidator(IMPLICIT_SUFFIX_COLUMN_LABEL,
"suffix");
    +  String IMPLICIT_FQN_COLUMN_LABEL = "drill.exec.storage.implicit.fqn.column.label";
    +  OptionValidator IMPLICIT_FQN_COLUMN_LABEL_VALIDATOR = new StringValidator(IMPLICIT_FQN_COLUMN_LABEL,
"fqn");
    +  String IMPLICIT_DIRNAME_COLUMN_LABEL = "drill.exec.storage.implicit.dirname.column.label";
    --- End diff --
    
    Probably better to name this PATH or FILEPATH instead of DIRNAME to prevent confusion
with DIR[0-9]


> Add implicit file columns support
> ---------------------------------
>
>                 Key: DRILL-3474
>                 URL: https://issues.apache.org/jira/browse/DRILL-3474
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Metadata
>    Affects Versions: 1.1.0
>            Reporter: Jim Scott
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> I could not find another ticket which talks about this ...
> The file name should be a column which can be selected or filtered when querying a directory
just like dir0, dir1 are available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message