drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4604) Generate warning on Web UI if drillbits version mismatch is detected
Date Tue, 26 Apr 2016 16:51:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258430#comment-15258430
] 

ASF GitHub Bot commented on DRILL-4604:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r61121843
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
    @@ -55,44 +59,89 @@ public Viewable getStats() {
       @GET
       @Path("/stats.json")
       @Produces(MediaType.APPLICATION_JSON)
    -  public List<Stat> getStatsJSON() {
    -    List<Stat> stats = Lists.newLinkedList();
    -    stats.add(new Stat("Number of Drill Bits", work.getContext().getBits().size()));
    -    int number = 0;
    -    for (CoordinationProtos.DrillbitEndpoint bit : work.getContext().getBits()) {
    -      String initialized = bit.isInitialized() ? " initialized" : " not initialized";
    -      stats.add(new Stat("Bit #" + number, bit.getAddress() + initialized));
    -      ++number;
    +  public Stats getStatsJSON() {
    +    String version = work.getContext().getOptionManager().getOption(ExecConstants.CLUSTER_VERSION).string_val;
    --- End diff --
    
    Hmm there's a problem then.. Default values (`DrillVersionInfo.getVersion()`) are not
put in the persistent store, meaning each Drillbit would start with its own version, and the
intended warning will not be generated.


> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
>                 Key: DRILL-4604
>                 URL: https://issues.apache.org/jira/browse/DRILL-4604
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: 1.7.0
>
>         Attachments: index_page.JPG, index_page_mismatch.JPG
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match with current
drillbit, generate warning.
> Screenshots - TBA.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message