drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4596) Drill should do version check among drillbits
Date Mon, 11 Apr 2016 16:26:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235409#comment-15235409
] 

ASF GitHub Bot commented on DRILL-4596:
---------------------------------------

Github user yufeldman commented on the pull request:

    https://github.com/apache/drill/pull/474#issuecomment-208434359
  
    Should it be +-1, not just +1 ? Otherwise in your scheme 1.9 can work with
    2.0, but can not with 1.8, while 1.8 can work with 1.9.
    
    On Mon, Apr 11, 2016 at 9:08 AM, arina-ielchiieva <notifications@github.com>
    wrote:
    
    > Updated PR.
    > New implementation approach:
    > 1. we allow to register any drillbit (disregarding the version).
    > 2. instead of getting available endpoints from coordinator, we'll be
    > receiving compatible endpoints. Version compatibility will be defined using
    > main application version (major.minor (+ 1). For example, drillbit with
    > version 1.8 can work with 1.8 and 1.9. Drillbit with version 1.9 can work
    > with 1.9 and 2.0 and so on. Even during rolling upgrades, compatible
    > endpoints will be able to work together.
    >
    > —
    > You are receiving this because you commented.
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/drill/pull/474#issuecomment-208428822>
    >



> Drill should do version check among drillbits
> ---------------------------------------------
>
>                 Key: DRILL-4596
>                 URL: https://issues.apache.org/jira/browse/DRILL-4596
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Before registering new drillbit in zookeeper, we should do version check, and make sure
all the running drillbits are in the same version.
> Using drillbits of different version can lead to unexpected results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message