drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4596) Drill should do version check among drillbits
Date Fri, 08 Apr 2016 17:58:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232602#comment-15232602
] 

ASF GitHub Bot commented on DRILL-4596:
---------------------------------------

Github user JohnOmernik commented on a diff in the pull request:

    https://github.com/apache/drill/pull/474#discussion_r59064857
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    +   * Disallow registering drillbit when:
    +   * 1. version is unknown;
    +   * 2. drillbit with different version has been already registered.
    --- End diff --
    
    Agreed.  In addition to potential soft enforcement, I think we should consider the differences
of a version defined in a pom.xml, the version of the running drillbit, and the version of
a drill cluster.  By using a setting in drill-override to specify what the drill cluster version
is, we don't get accident "first bit to register is the wrong version" situations.  Are there
situations where we might want to allow a specific Drill version + all minor versions at that
level, or Drill version + 1 Major version for rolling upgrades?


> Drill should do version check among drillbits
> ---------------------------------------------
>
>                 Key: DRILL-4596
>                 URL: https://issues.apache.org/jira/browse/DRILL-4596
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Before registering new drillbit in zookeeper, we should do version check, and make sure
all the running drillbits are in the same version.
> Using drillbits of different version can lead to unexpected results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message