drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4576) Add StoragePlugin API to register materialization into planner
Date Wed, 13 Apr 2016 15:47:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239465#comment-15239465

ASF GitHub Bot commented on DRILL-4576:

Github user laurentgo commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java
    @@ -0,0 +1,59 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.planner;
    +import java.util.Collection;
    +import org.apache.calcite.plan.RelOptPlanner;
    + * A callback that StoragePlugins can initialize to allow further configuration
    + * of the Planner at initialization time. Examples could be to allow adding lattices,
    + * materializations or additional traits to the planner that will be used in
    + * planning.
    + */
    +public abstract class PlannerCallback {
    --- End diff --
    Hope you can share your thoughts regarding `Function<>`, I might have spent too
much time doing functional programming in the past years :) interfaces are usually easier
to mock. Also with java8, you can annotate them with `@FunctionInterface` and use lambda expression
directly (but also in java8 you can add default methods to interface which makes abstract
classes less compulsory as a way of not breaking backward compatibility).

> Add StoragePlugin API to register materialization into planner
> --------------------------------------------------------------
>                 Key: DRILL-4576
>                 URL: https://issues.apache.org/jira/browse/DRILL-4576
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Laurent Goujon
>            Assignee: Jacques Nadeau
> There's no currently a good way to register materializations into Drill planner. Calcite's
MaterializationService.instance() would be the way to go, but the registration happens in
{{org.apache.calcite.prepare.Prepare.PreparedResult#prepareSql()}}, which is not called by

This message was sent by Atlassian JIRA

View raw message