drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4576) Add StoragePlugin API to register materialization into planner
Date Wed, 06 Apr 2016 02:32:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227587#comment-15227587
] 

ASF GitHub Bot commented on DRILL-4576:
---------------------------------------

GitHub user jacques-n opened a pull request:

    https://github.com/apache/drill/pull/466

    DRILL-4576: Add PlannerCallback interface for additional planner initialization.

    DRILL-4576: Add PlannerCallback interface for additional planner initialization.
    
    - Allow a storage plugin to be able to provide additional planner initialization.
    - Fix issue in StoragePluginRegistryImpl which deletes manually added plugins from the
registry since they don't exist in the PersistentStore.
    - Add a simple test to ensure Callbacks are correctly registered and executed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jacques-n/drill DRILL-4576

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #466
    
----
commit 81c5ad8ff1fb1fa20ac98c824b159dea60ce53aa
Author: Jacques Nadeau <jacques@apache.org>
Date:   2016-04-06T02:29:20Z

    DRILL-4576: Add PlannerCallback interface for additional planner initialization.
    
    - Allow a storage plugin to be able to provide additional planner initialization.
    - Fix issue in StoragePluginRegistryImpl which deletes manually added plugins from the
registry since they don't exist in the PersistentStore.
    - Add a simple test to ensure Callbacks are correctly registered and executed.

----


> Add StoragePlugin API to register materialization into planner
> --------------------------------------------------------------
>
>                 Key: DRILL-4576
>                 URL: https://issues.apache.org/jira/browse/DRILL-4576
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Laurent Goujon
>            Assignee: Jacques Nadeau
>
> There's no currently a good way to register materializations into Drill planner. Calcite's
MaterializationService.instance() would be the way to go, but the registration happens in
{{org.apache.calcite.prepare.Prepare.PreparedResult#prepareSql()}}, which is not called by
Drill.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message