drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4527) Remove unnecessary code: DrillAvgVarianceConvertlet.java
Date Tue, 12 Apr 2016 20:48:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237950#comment-15237950
] 

ASF GitHub Bot commented on DRILL-4527:
---------------------------------------

Github user vkorukanti commented on the pull request:

    https://github.com/apache/drill/pull/441#issuecomment-209095889
  
    LGTM, +1


> Remove unnecessary code:  DrillAvgVarianceConvertlet.java
> ---------------------------------------------------------
>
>                 Key: DRILL-4527
>                 URL: https://issues.apache.org/jira/browse/DRILL-4527
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>            Reporter: MinJi Kim
>            Assignee: MinJi Kim
>
> DrillConvertletTable is used as a way to have custom functions.  For example, for EXTRACT(),
DrilLConvertletTable.get() returns DrillExtractConvertlet, which returns a custom RexNode
for the extract function.  
> On the other hand, DrillAvgVarianceConvertlet is never used.  stddev/avg/variance functions
are handled by DrillAggregateRule and DrillReduceAggregatesRule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message