drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4523) Disallow using loopback address in distributed mode
Date Mon, 04 Apr 2016 10:54:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223939#comment-15223939
] 

ASF GitHub Bot commented on DRILL-4523:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/445#discussion_r58358260
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
    @@ -177,6 +182,18 @@ public void run() {
         });
       }
     
    +  /** If we are in distributed mode, disallow using loopback address to register new
drillbit
    +   *  unless zookeeper is on the same node with drillbit. */
    +  private void checkLoopbackAddress(String address) throws DrillbitStartupException,
UnknownHostException {
    +    if (isDistributedMode) {
    +      String coordAddress = StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION),
":");
    +      if (!InetAddress.getByName(coordAddress).isLoopbackAddress()
    --- End diff --
    
    At some point, we wanted to allow loopback only if we have one node only but it's much
safer to disallow loopback in distributed mode at all. Updated pull request.


> Disallow using loopback address in distributed mode
> ---------------------------------------------------
>
>                 Key: DRILL-4523
>                 URL: https://issues.apache.org/jira/browse/DRILL-4523
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components:  Server
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: 1.7.0
>
>
> If we enable debug for org.apache.drill.exec.coord.zk in logback.xml, we only get the
hostname and ports information. For example:
> {code}
> 2015-11-04 19:47:02,927 [ServiceCache-0] DEBUG o.a.d.e.c.zk.ZKClusterCoordinator - Cache
changed, updating.
> 2015-11-04 19:47:02,932 [ServiceCache-0] DEBUG o.a.d.e.c.zk.ZKClusterCoordinator - Active
drillbit set changed.  Now includes 2 total bits.  New active drillbits:
>  h3.poc.com:31010:31011:31012
>  h2.poc.com:31010:31011:31012
> {code}
> We need to know the IP address of each hostname to do further troubleshooting.
> Imagine if any drillbit registers itself as "localhost.localdomain" in zookeeper, we
will never know where it comes from. Enabling IP address tracking can help this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message