drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4132) Ability to submit simple type of physical plan directly to EndPoint DrillBit for execution
Date Thu, 28 Apr 2016 19:56:12 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262834#comment-15262834
] 

ASF GitHub Bot commented on DRILL-4132:
---------------------------------------

Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/368#discussion_r61492206
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/PlanSplitter.java
---
    @@ -0,0 +1,142 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.work.user;
    +
    +import java.util.List;
    +
    +import org.apache.drill.exec.ops.QueryContext;
    +import org.apache.drill.exec.physical.PhysicalPlan;
    +import org.apache.drill.exec.physical.base.PhysicalOperator;
    +import org.apache.drill.exec.planner.fragment.Fragment;
    +import org.apache.drill.exec.planner.fragment.MakeFragmentsVisitor;
    +import org.apache.drill.exec.planner.fragment.SimpleParallelizer;
    +import org.apache.drill.exec.planner.fragment.contrib.SimpleParallelizerMultiPlans;
    +import org.apache.drill.exec.planner.sql.DrillSqlWorker;
    +import org.apache.drill.exec.proto.BitControl.PlanFragment;
    +import org.apache.drill.exec.proto.UserBitShared.DrillPBError;
    +import org.apache.drill.exec.proto.UserBitShared.QueryId;
    +import org.apache.drill.exec.proto.UserBitShared.QueryResult.QueryState;
    +import org.apache.drill.exec.proto.UserProtos.GetQueryPlanFragments;
    +import org.apache.drill.exec.proto.UserProtos.QueryPlanFragments;
    +import org.apache.drill.exec.rpc.user.UserServer.UserClientConnection;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.util.MemoryAllocationUtilities;
    +import org.apache.drill.exec.util.Pointer;
    +import org.apache.drill.exec.util.Utilities;
    +import org.apache.drill.exec.work.QueryWorkUnit;
    +
    +import com.google.common.collect.Lists;
    +
    +/**
    + * Helper class to return PlanFragments based on the query plan
    + * or based on split query plan
    + *
    + */
    +public class PlanSplitter {
    +  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(PlanSplitter.class);
    +
    +  private static PlanSplitter s_instance = new PlanSplitter();
    +
    +  private PlanSplitter() {
    +
    +  }
    +
    +  public static PlanSplitter getInstance() {
    +    return s_instance;
    --- End diff --
    
    This seems a very cheap object used once per query. Why to make it singleton? We should
create it in the stack/heap as we need.


> Ability to submit simple type of physical plan directly to EndPoint DrillBit for execution
> ------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4132
>                 URL: https://issues.apache.org/jira/browse/DRILL-4132
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Execution - Flow, Execution - RPC, Query Planning & Optimization
>            Reporter: Yuliya Feldman
>            Assignee: Yuliya Feldman
>
> Today Drill Query execution is optimistic and stateful (at least due to data exchanges)
- if any of the stages of query execution fails whole query fails. If query is just simple
scan, filter push down and project where no data exchange happens between DrillBits there
is no need to fail whole query when one DrillBit fails, as minor fragments running on that
DrillBit can be rerun on the other DrillBit. There are probably multiple ways to achieve this.
This JIRA is to open discussion on: 
> 1. agreement that we need to support above use case 
> 2. means of achieving it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message