Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 490BB1860C for ; Wed, 9 Mar 2016 00:53:41 +0000 (UTC) Received: (qmail 94305 invoked by uid 500); 9 Mar 2016 00:53:41 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 94243 invoked by uid 500); 9 Mar 2016 00:53:41 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 93993 invoked by uid 99); 9 Mar 2016 00:53:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2016 00:53:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B4CD82C14F4 for ; Wed, 9 Mar 2016 00:53:40 +0000 (UTC) Date: Wed, 9 Mar 2016 00:53:40 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4491) FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-4491?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1518= 6220#comment-15186220 ]=20 ASF GitHub Bot commented on DRILL-4491: --------------------------------------- GitHub user adityakishore opened a pull request: https://github.com/apache/drill/pull/418 DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig= =E2=80=A6 =E2=80=A6 fields to be public You can merge this pull request into a Git repository by running: $ git pull https://github.com/adityakishore/drill DRILL-4491 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/418.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #418 =20 ---- commit cce8467c2476da871891bad7db6cab3236537f7c Author: Aditya Kishore Date: 2016-03-09T00:49:55Z DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig f= ields to be public ---- > FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be pu= blic > -------------------------------------------------------------------------= ---- > > Key: DRILL-4491 > URL: https://issues.apache.org/jira/browse/DRILL-4491 > Project: Apache Drill > Issue Type: Bug > Reporter: Aditya Kishore > Assignee: Aditya Kishore > Priority: Minor > Fix For: 1.7.0 > > > The code uses {{getField()}} instead of {{getDeclaredField()}}, which ret= urns only the public fields. > {code:title=3DFormatPluginOptionsDescriptor.java:165|borderStyle=3Dsolid} > Field field =3D pluginConfigClass.getField(paramDef.name); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)