drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4549) Add support for more truncation units in date_trunc function
Date Mon, 28 Mar 2016 23:52:25 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215109#comment-15215109
] 

ASF GitHub Bot commented on DRILL-4549:
---------------------------------------

GitHub user vkorukanti opened a pull request:

    https://github.com/apache/drill/pull/450

    DRILL-4549: Add support for more truncation units in date_trunc function

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vkorukanti/drill DRILL-4549

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #450
    
----
commit 89fc8462497e162772b56d6d45bca0074fbe3e43
Author: vkorukanti <venki@dremio.com>
Date:   2016-03-28T18:09:34Z

    DRILL-4549: Add support for more truncation units in date_trunc function

----


> Add support for more truncation units in date_trunc function
> ------------------------------------------------------------
>
>                 Key: DRILL-4549
>                 URL: https://issues.apache.org/jira/browse/DRILL-4549
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>             Fix For: 1.7.0
>
>
> Currently we support only {{YEAR, MONTH, DAY, HOUR, MINUTE, SECOND}} truncate units for
types {{TIME, TIMESTAMP and DATE}}. Extend the functions to support {{YEAR, MONTH, DAY, HOUR,
MINUTE, SECOND, WEEK, QUARTER, DECADE, CENTURY, MILLENNIUM}} truncate units for types {{TIME,
TIMESTAMP, DATE, INTERVAL DAY, INTERVAL YEAR}}.
> Also get rid of the if-and-else (on truncation unit) implementation. Instead resolve
to a direct function based on the truncation unit in Calcite -> Drill (DrillOptiq) expression
conversion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message