drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4486) Expression serializer incorrectly serializes escaped characters
Date Tue, 08 Mar 2016 01:42:40 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184196#comment-15184196
] 

ASF GitHub Bot commented on DRILL-4486:
---------------------------------------

Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/412#discussion_r55304775
  
    --- Diff: logical/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java
---
    @@ -119,14 +126,14 @@ public Void visitSchemaPath(SchemaPath path, StringBuilder sb) throws
RuntimeExc
           throw new IllegalStateException("Drill doesn't currently support top level arrays");
         }
         sb.append('`');
    -    sb.append(seg.getNameSegment().getPath());
    +    sb.append(escapeBackTick(seg.getNameSegment().getPath()));
    --- End diff --
    
    Should getPath() ever return something that cannot be parsed, should we just add this
behavior there?


> Expression serializer incorrectly serializes escaped characters
> ---------------------------------------------------------------
>
>                 Key: DRILL-4486
>                 URL: https://issues.apache.org/jira/browse/DRILL-4486
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Steven Phillips
>            Assignee: Steven Phillips
>
> the drill expression parser requires backslashes to be escaped. But the ExpressionStringBuilder
is not properly escaping them. This causes problems, especially in the case of regex expressions
run with parallel execution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message