drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aman Sinha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4472) Pushing Filter past Union All fails: DRILL-3257 regressed DRILL-2746 but unit test update break test goal
Date Fri, 04 Mar 2016 16:28:40 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180097#comment-15180097
] 

Aman Sinha commented on DRILL-4472:
-----------------------------------

Assigning to [~seanhychu] who wrote the unit test...I will follow up with him to see why the
IN filter is not getting pushed past union-all. 

> Pushing Filter past Union All fails: DRILL-3257 regressed DRILL-2746 but unit test update
break test goal
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4472
>                 URL: https://issues.apache.org/jira/browse/DRILL-4472
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>            Reporter: Jacques Nadeau
>            Assignee: Sean Hsuan-Yi Chu
>
> While reviewing DRILL-4467, I discovered this test. 
> https://github.com/apache/drill/blame/master/exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java#L560
> As you can see, the test is checking that test name confirms that filter is pushed below
union all. However, as you can see, the expected result in DRILL-3257 was updated to a plan
which doesn't push the in clause below the filter. I'm disabling the test since 4467 happens
to remove what becomes a trivial project. However, we really should fix the core problem (a
regression of DRILL-2746.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message