Return-Path: 
 <issues-return-28837-apmail-drill-issues-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-issues-archive@minotaur.apache.org
Delivered-To: apmail-drill-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 52559184D9
	for <apmail-drill-issues-archive@minotaur.apache.org>;
 Mon, 15 Feb 2016 02:31:18 +0000 (UTC)
Received: (qmail 85447 invoked by uid 500); 15 Feb 2016 02:31:18 -0000
Delivered-To: apmail-drill-issues-archive@drill.apache.org
Received: (qmail 85418 invoked by uid 500); 15 Feb 2016 02:31:18 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 85398 invoked by uid 99); 15 Feb 2016 02:31:18 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2016 02:31:18 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 15BB52C14F3
	for <issues@drill.apache.org>; Mon, 15 Feb 2016 02:31:18 +0000 (UTC)
Date: Mon, 15 Feb 2016 02:31:18 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12932568.1453247420000.50814.1455503478083@Atlassian.JIRA>
In-Reply-To: <JIRA.12932568.1453247420000@Atlassian.JIRA>
References: <JIRA.12932568.1453247420000@Atlassian.JIRA>
 <JIRA.12932568.1453247420005@arcas>
Subject: [jira] [Commented] (DRILL-4287) Do lazy reading of parquet metadata
 cache file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DRILL-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146847#comment-15146847 ] 

ASF GitHub Bot commented on DRILL-4287:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/376#discussion_r52854886
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java ---
    @@ -157,7 +159,20 @@ private String getBaseTableLocation() {
     
       @Override
       protected void createPartitionSublists() {
    -    List<String> fileLocations = ((FormatSelection) table.getSelection()).getAsFiles();
    +    Collection<String> fileLocations = null;
    +    if (scanRel instanceof DrillScanRel) {
    --- End diff --
    
    This seems like it is leaking specific implementations. Can we come up with a way to move this around. Possibly GroupScan should have hasFiles() and getFiles()?


> Do lazy reading of parquet metadata cache file
> ----------------------------------------------
>
>                 Key: DRILL-4287
>                 URL: https://issues.apache.org/jira/browse/DRILL-4287
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.4.0
>            Reporter: Aman Sinha
>            Assignee: Jinfeng Ni
>
> Currently, the parquet metadata cache file is read eagerly during creation of the DrillTable (as part of ParquetFormatMatcher.isReadable()).  This is not desirable from performance standpoint since there are scenarios where we want to do some up-front optimizations - e.g. directory-based partition pruning (see DRILL-2517) or potential limit 0 optimization etc. - and in such situations it is better to do lazy reading of the metadata cache file.   
> This is a placeholder to perform such delayed reading since it is needed for the aforementioned optimizations.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)