Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBD8518F55 for ; Tue, 2 Feb 2016 18:37:47 +0000 (UTC) Received: (qmail 37513 invoked by uid 500); 2 Feb 2016 18:37:40 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 37402 invoked by uid 500); 2 Feb 2016 18:37:40 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 37220 invoked by uid 99); 2 Feb 2016 18:37:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 18:37:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 3E6982C0AFA for ; Tue, 2 Feb 2016 18:37:40 +0000 (UTC) Date: Tue, 2 Feb 2016 18:37:40 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4287) Do lazy reading of parquet metadata cache file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128754#comment-15128754 ] ASF GitHub Bot commented on DRILL-4287: --------------------------------------- Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/345#discussion_r51612851 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -338,8 +354,14 @@ private boolean hasSingleValue(ColumnMetadata columnChunkMetaData) { return (columnChunkMetaData != null) && (columnChunkMetaData.hasSingleValue()); } + @Override --- End diff -- Right. > Do lazy reading of parquet metadata cache file > ---------------------------------------------- > > Key: DRILL-4287 > URL: https://issues.apache.org/jira/browse/DRILL-4287 > Project: Apache Drill > Issue Type: Bug > Components: Query Planning & Optimization > Affects Versions: 1.4.0 > Reporter: Aman Sinha > Assignee: Jinfeng Ni > > Currently, the parquet metadata cache file is read eagerly during creation of the DrillTable (as part of ParquetFormatMatcher.isReadable()). This is not desirable from performance standpoint since there are scenarios where we want to do some up-front optimizations - e.g. directory-based partition pruning (see DRILL-2517) or potential limit 0 optimization etc. - and in such situations it is better to do lazy reading of the metadata cache file. > This is a placeholder to perform such delayed reading since it is needed for the aforementioned optimizations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)