Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CFF9118DD4 for ; Thu, 18 Feb 2016 08:35:16 +0000 (UTC) Received: (qmail 70307 invoked by uid 500); 18 Feb 2016 08:34:18 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 70279 invoked by uid 500); 18 Feb 2016 08:34:18 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 70262 invoked by uid 99); 18 Feb 2016 08:34:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Feb 2016 08:34:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2F5212C1F62 for ; Thu, 18 Feb 2016 08:34:18 +0000 (UTC) Date: Thu, 18 Feb 2016 08:34:18 +0000 (UTC) From: "Khurram Faraaz (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4257) Ensure shutting down a Drillbit also shuts down all StoragePlugins MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-4257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151944#comment-15151944 ] Khurram Faraaz commented on DRILL-4257: --------------------------------------- Do we have a unit test to verify this ? Is there a way to verify this from the drillbit.log, that all StoragePlugins are also shut down once a Drillbit is shut down ? > Ensure shutting down a Drillbit also shuts down all StoragePlugins > ------------------------------------------------------------------ > > Key: DRILL-4257 > URL: https://issues.apache.org/jira/browse/DRILL-4257 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Reporter: Jacques Nadeau > Assignee: Jacques Nadeau > Fix For: 1.5.0 > > > Right now, if a StoragePlugin implementation relies on the close method to clean up resources, those resources won't be cleaned up when the Drillbit class is shutdown. This is because Drillbit doesn't actually close the StoragePluginRegistry and associated resources. This causes problems in leaking resources in tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)