drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-4445) Remove extra code to work around mixture of arrays and Lists used in Logical and Physical query plan nodes
Date Fri, 26 Feb 2016 18:39:18 GMT
Jason Altekruse created DRILL-4445:
--------------------------------------

             Summary: Remove extra code to work around mixture of arrays and Lists used in
Logical and Physical query plan nodes
                 Key: DRILL-4445
                 URL: https://issues.apache.org/jira/browse/DRILL-4445
             Project: Apache Drill
          Issue Type: Improvement
            Reporter: Jason Altekruse
            Assignee: Jason Altekruse


The physical plan node classes for all of the operators currently use a mix of arrays and
Lists to refer to lists of incoming operators, expressions, and other operator properties.
This had lead to the introduction of several utility methods for translating between the two
representations, examples can be seen in common/logical/data/Abstractbuilder.

This isn't a major problem, but the new operator test framework uses these classes as a primary
interface for setting up the tests. It seemed worthwhile to just refactor the classes to be
consistent so that the tests would all be similar. There are a few changes to execution code,
but they are all just trivial changes to use the list based interfaces (length vs size(),
set() instead of arr[i] = foo, etc.) as Jackson just transparently handles both types the
same (which is why this hasn't really been a problem).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message