drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deneche A. Hakim (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4423) TestCsvHeader#testEmptyFinalColumn is causing the unit test framework to print 10K rows in Stdout
Date Mon, 22 Feb 2016 21:44:18 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157751#comment-15157751
] 

Deneche A. Hakim commented on DRILL-4423:
-----------------------------------------

[~sudheeshkatkam] can you review this please ?

> TestCsvHeader#testEmptyFinalColumn is causing the unit test framework to print 10K rows
in Stdout
> -------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4423
>                 URL: https://issues.apache.org/jira/browse/DRILL-4423
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Tools, Build & Test
>    Affects Versions: 1.5.0
>            Reporter: Deneche A. Hakim
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.6.0
>
>
> This unit test is printing 10.000 rows all equal to the following line:
> {noformat}
> field2(VARCHAR:REQUIRED)[$offsets$(UINT4:REQUIRED)]
> {noformat}
> DrillTestWrapper contains the following code in 2 separate methods that prints a field's
details whenever an "empty" value is encountered:
> {code}
>             if (obj instanceof Text) {
>               obj = obj.toString();
>               if (obj.equals("")) {
>                 System.out.println(w.getField());
>               }
>             }
> {code}
> Because this particular unit test was creating 10K rows with an empty field, it was causing
lot's of output to Stdout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message