drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4354) Remove sessions in anonymous (user auth disabled) mode in WebUI server
Date Fri, 26 Feb 2016 17:25:18 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169363#comment-15169363
] 

ASF GitHub Bot commented on DRILL-4354:
---------------------------------------

Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/360#discussion_r54273249
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
---
    @@ -60,13 +63,21 @@ public String getName() {
       }
     
       /**
    -   * @return Return {@link DrillClient} instanced with credentials of this user principal.
    +   * @return Return {@link DrillClient} instanced with credentials of this user principal.
Returned {@link DrillClient}
    +   * must be returned using {@link #recycleDrillClient(DrillClient)} for proper resource
cleanup.
        */
    -  public DrillClient getDrillClient() {
    +  public DrillClient getDrillClient() throws IOException {
         return drillClient;
       }
     
       /**
    +   *
    --- End diff --
    
    added javadoc.


> Remove sessions in anonymous (user auth disabled) mode in WebUI server
> ----------------------------------------------------------------------
>
>                 Key: DRILL-4354
>                 URL: https://issues.apache.org/jira/browse/DRILL-4354
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>    Affects Versions: 1.5.0
>            Reporter: Venki Korukanti
>            Assignee: Venki Korukanti
>             Fix For: 1.6.0
>
>
> Currently we open anonymous sessions when user auth disabled. These sessions are cleaned
up when they expire (controlled by boot config {{drill.exec.http.session_max_idle_secs}}).
This may lead to unnecessary resource accumulation. This JIRA is to remove anonymous sessions
and only have sessions when user authentication is enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message