drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4327) Fix rawtypes warning emitted by compiler
Date Fri, 05 Feb 2016 17:51:39 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134566#comment-15134566
] 

ASF GitHub Bot commented on DRILL-4327:
---------------------------------------

Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/347#discussion_r52048800
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java
---
    @@ -26,13 +26,13 @@
     import org.apache.drill.exec.ops.FragmentContext;
     import org.apache.drill.exec.ops.OperatorStats;
     import org.apache.drill.exec.record.RecordBatch;
    -
    --- End diff --
    
    don't have a very strong opinion on this, but there seem to be a lot of shifting of imports
without actually changing them, are you standardizing the order? I don't think we have a lot
of outstanding patches that will have merge issues as a result, but we generally try to avoid
cosmetic changes, especially mixed in with other work.


> Fix rawtypes warning emitted by compiler
> ----------------------------------------
>
>                 Key: DRILL-4327
>                 URL: https://issues.apache.org/jira/browse/DRILL-4327
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>            Priority: Minor
>
> The Drill codebase references lots of rawtypes, which generates lots of warning from
the compiler.
> Since Drill is now compiled with Java 1.7, it should use generic types as much as possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message