Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D1441876A for ; Sun, 17 Jan 2016 19:27:40 +0000 (UTC) Received: (qmail 61011 invoked by uid 500); 17 Jan 2016 19:27:40 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 60981 invoked by uid 500); 17 Jan 2016 19:27:39 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 60970 invoked by uid 99); 17 Jan 2016 19:27:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Jan 2016 19:27:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C274B2C14F0 for ; Sun, 17 Jan 2016 19:27:39 +0000 (UTC) Date: Sun, 17 Jan 2016 19:27:39 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4275) Refactor e/pstore interfaces and their factories to provide a unified mechanism to access stores MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103880#comment-15103880 ] ASF GitHub Bot commented on DRILL-4275: --------------------------------------- Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172369155 You want to do a hangout to discuss the concept of EStores and watches and the relationship with the ClusterCoordinator interface. We're currently actively in the process of implementing a new EStore/PStore pair and I'd like to figure out the best way to improve the interface without major disruption to the work we're doing. > Refactor e/pstore interfaces and their factories to provide a unified mechanism to access stores > ------------------------------------------------------------------------------------------------ > > Key: DRILL-4275 > URL: https://issues.apache.org/jira/browse/DRILL-4275 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Flow > Reporter: Hanifi Gunes > Assignee: Deneche A. Hakim > > We rely on E/PStore interfaces to persist data. Even though E/PStore stands for Ephemeral and Persistent stores respectively, the current design for EStore does not extend the interface/functionality of PStore at all, which hints abstraction for EStore is redundant. This issue proposes a new unified Store interface replacing the old E/PStore that exposes an additional method that report persistence level as follows: > {code:title=Store interface} > interface Store { > StoreMode getMode(); > V get(String key); > ... > } > enum StoreMode { > EPHEMERAL, > PERSISTENT, > ... > } > {code} > The new design brings in less redundancy, more centralized code, ease to reason and maintain. -- This message was sent by Atlassian JIRA (v6.3.4#6332)