Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10CF6186EF for ; Wed, 13 Jan 2016 21:22:40 +0000 (UTC) Received: (qmail 89834 invoked by uid 500); 13 Jan 2016 21:22:40 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 89799 invoked by uid 500); 13 Jan 2016 21:22:40 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 89775 invoked by uid 99); 13 Jan 2016 21:22:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 21:22:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D44CE2C14F0 for ; Wed, 13 Jan 2016 21:22:39 +0000 (UTC) Date: Wed, 13 Jan 2016 21:22:39 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-4270?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1509= 7015#comment-15097015 ]=20 ASF GitHub Bot commented on DRILL-4270: --------------------------------------- GitHub user adeneche opened a pull request: https://github.com/apache/drill/pull/322 DRILL-4270: Create a separate WindowFramer that supports the FRAME cl= =E2=80=A6 =E2=80=A6ause =20 separate DefaultFrameTemplate into 2 implementations: one that supports= custom frames (aggregations, first_value, last_value) and one that doesn't You can merge this pull request into a Git repository by running: $ git pull https://github.com/adeneche/incubator-drill DRILL-4270 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 =20 ---- commit 8bcde155d23550d6733f4dcb18868bdc3fb3b119 Author: adeneche Date: 2016-01-11T22:47:32Z DRILL-4270: Create a separate WindowFramer that supports the FRAME clau= se =20 separate DefaultFrameTemplate into 2 implementations: one that supports= custom frames (aggregations, first_value, last_value) and one that doesn't ---- > Create a separate WindowFramer that supports the FRAME clause > ------------------------------------------------------------- > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators > Affects Versions: 1.5.0 > Reporter: Deneche A. Hakim > Assignee: Deneche A. Hakim > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTempl= ate. Create a separate CustomFrameTemplate that handles the FRAME clause, t= his should make the code in both classes more focused and will make it easi= er for us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by CustomFrameTe= mplate, and all remaining window functions (Ranking, ROW_NUMBER, LEAD and L= AG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)