Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69D7118887 for ; Thu, 14 Jan 2016 17:31:40 +0000 (UTC) Received: (qmail 56625 invoked by uid 500); 14 Jan 2016 17:31:40 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 56537 invoked by uid 500); 14 Jan 2016 17:31:40 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 56520 invoked by uid 99); 14 Jan 2016 17:31:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jan 2016 17:31:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CE2672C1F57 for ; Thu, 14 Jan 2016 17:31:39 +0000 (UTC) Date: Thu, 14 Jan 2016 17:31:39 +0000 (UTC) From: "Victoria Markman (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-4236) ExternalSort should use the new allocator functionality to better manage it's memory usage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098466#comment-15098466 ] Victoria Markman commented on DRILL-4236: ----------------------------------------- I agree that it's a separate bug and I was combing jira to find existing bug, because it's always been the case that sort could run out of memory in some specific conditions. Is this something we are going to fix for 1.5.0 and hold release for ? > ExternalSort should use the new allocator functionality to better manage it's memory usage > ------------------------------------------------------------------------------------------ > > Key: DRILL-4236 > URL: https://issues.apache.org/jira/browse/DRILL-4236 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Relational Operators > Affects Versions: 1.5.0 > Reporter: Deneche A. Hakim > Assignee: Deneche A. Hakim > Labels: documentation > Fix For: 1.5.0 > > > Before DRILL-4215, the sort operator wasn't able to correctly compute it's memory usage, and so it jumped through a bunch of hoops to try to figure out when it should spill to disk. > With the transfer accounting in place, this code can be greatly simplified to just use the current operator memory allocation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)