drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
Date Mon, 18 Jan 2016 18:40:39 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105630#comment-15105630

ASF GitHub Bot commented on DRILL-4270:

Github user amansinha100 commented on the pull request:

    Renaming sounds fine to avoid misinterpretation.  +1. 

> Create a separate WindowFramer that supports the FRAME clause
> -------------------------------------------------------------
>                 Key: DRILL-4270
>                 URL: https://issues.apache.org/jira/browse/DRILL-4270
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Relational Operators
>    Affects Versions: 1.5.0
>            Reporter: Deneche A. Hakim
>            Assignee: Aman Sinha
>             Fix For: Future
> Currently most the window functions logic is handled by DefaultFrameTemplate. Create
a separate CustomFrameTemplate that handles the FRAME clause, this should make the code in
both classes more focused and will make it easier for us to add support for the FRAME clause.
> Aggregations, FIRST_VALUE and LAST_VALUE will be handled by CustomFrameTemplate, and
all remaining window functions (Ranking, ROW_NUMBER, LEAD and LAG) will be handled by DefaultFrameTemplate.

This message was sent by Atlassian JIRA

View raw message