drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
Date Wed, 13 Jan 2016 21:22:39 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097015#comment-15097015
] 

ASF GitHub Bot commented on DRILL-4270:
---------------------------------------

GitHub user adeneche opened a pull request:

    https://github.com/apache/drill/pull/322

    DRILL-4270: Create a separate WindowFramer that supports the FRAME cl…

    …ause
    
    separate DefaultFrameTemplate into 2 implementations: one that supports custom frames
(aggregations, first_value, last_value) and one that doesn't

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adeneche/incubator-drill DRILL-4270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #322
    
----
commit 8bcde155d23550d6733f4dcb18868bdc3fb3b119
Author: adeneche <adeneche@gmail.com>
Date:   2016-01-11T22:47:32Z

    DRILL-4270: Create a separate WindowFramer that supports the FRAME clause
    
    separate DefaultFrameTemplate into 2 implementations: one that supports custom frames
(aggregations, first_value, last_value) and one that doesn't

----


> Create a separate WindowFramer that supports the FRAME clause
> -------------------------------------------------------------
>
>                 Key: DRILL-4270
>                 URL: https://issues.apache.org/jira/browse/DRILL-4270
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Relational Operators
>    Affects Versions: 1.5.0
>            Reporter: Deneche A. Hakim
>            Assignee: Deneche A. Hakim
>             Fix For: Future
>
>
> Currently most the window functions logic is handled by DefaultFrameTemplate. Create
a separate CustomFrameTemplate that handles the FRAME clause, this should make the code in
both classes more focused and will make it easier for us to add support for the FRAME clause.
> Aggregations, FIRST_VALUE and LAST_VALUE will be handled by CustomFrameTemplate, and
all remaining window functions (Ranking, ROW_NUMBER, LEAD and LAG) will be handled by DefaultFrameTemplate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message