drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4215) Transfer ownership of buffers when doing transfers
Date Mon, 21 Dec 2015 21:05:46 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067057#comment-15067057

ASF GitHub Bot commented on DRILL-4215:

GitHub user StevenMPhillips opened a pull request:


    DRILL-4215: Transfer ownership in TransferPair

    Only commit 79bbfcb is part of this commit. But since the other commits haven't been merged
to master, they are also showing up in this PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StevenMPhillips/drill drill-4215

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #308
commit ea7bbc58f3e4bed5dc8093381d6c7dc4911f520e
Author: Chris Westin <cwestin@yahoo.com>
Date:   2015-11-11T22:57:16Z

    DRILL-4144: Clean up close behaviors.

commit da4f9821644520bf2c4eb698770ed87713b1a039
Author: Chris Westin <cwestin@yahoo.com>
Date:   2015-11-11T22:57:47Z

    DRILL-4144: Add new allocator

commit 728687f8d7c28d398ac993705dc0e4fb189b01d4
Author: Jacques Nadeau <jacques@apache.org>
Date:   2015-11-16T01:26:02Z

    DRILL-4144: Allocator Improvements
    - make Allocator mostly lockless
    - change BaseAllocator maps to direct references
    - add documentation around memory management model
    - move transfer and ownership methods to DrillBuf
    - Improve debug messaging.
    - Fix/revert sort changes
    - Remove unused fragment limit flag
    - Add time to HistoricalLog events
    - Remove reservation amount from RootAllocator constructor (since not allowed)
    - Fix concurrency issue where allocator is closing at same moment as incoming batch transfer,
causing leaked memory and/or query failure.
    - Add new AutoCloseables.close(Iterable<AutoCloseable>)
    - Remove extraneous DataResponseHandler and Impl (and update TestBitRpc to use smarter
mock of FragmentManager)
    - Remove the concept of poison pill record batches, using instead FragmentContext.isOverMemoryLimit()
    - Update incoming data batches so that they are transferred under protection of a close
    - Improve field names in IncomingBuffers and move synchronization to collectors as opposed
to IncomingBuffers (also change decrementing to decrementToZero rather than two part check).

commit 79bbfcb018429ad3a02daf2ac4dea119126041e1
Author: Steven Phillips <smp@apache.org>
Date:   2015-12-01T08:34:41Z

    DRILL-4215: Transfer buffer ownership in TransferPair


> Transfer ownership of buffers when doing transfers
> --------------------------------------------------
>                 Key: DRILL-4215
>                 URL: https://issues.apache.org/jira/browse/DRILL-4215
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Steven Phillips
>            Assignee: Steven Phillips
> The new allocator has the feature of allowing the transfer of ownership of buffers from
one allocator to another. We should make use of this feature by transferring ownership whenever
we transfer buffers between vectors. This will allow better tracking of how much memory operators
are holding on to.

This message was sent by Atlassian JIRA

View raw message