drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-4187) Introduce a state to separate queries pending execution from those pending in the queue.
Date Tue, 22 Dec 2015 22:36:46 GMT

    [ https://issues.apache.org/jira/browse/DRILL-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068844#comment-15068844

ASF GitHub Bot commented on DRILL-4187:

Github user sudheeshkatkam commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
    @@ -391,7 +397,10 @@ private void parseAndRunPhysicalPlan(final String json) throws ExecutionSetupExc
       private void runPhysicalPlan(final PhysicalPlan plan) throws ExecutionSetupException
    -    acquireQuerySemaphore(plan);
    +    if (queuingEnabled) {
    +      acquireQuerySemaphore(plan);
    +    }
    +    recordNewState(QueryState.STARTING);
    --- End diff --
    If the initialState is STARTING won't this fail (state transition from STARTING to STARTING
is invalid given the fall-through)? The recordNewState(STARTING) should be inside the if condition,

> Introduce a state to separate queries pending execution from those pending in the queue.
> ----------------------------------------------------------------------------------------
>                 Key: DRILL-4187
>                 URL: https://issues.apache.org/jira/browse/DRILL-4187
>             Project: Apache Drill
>          Issue Type: Sub-task
>            Reporter: Hanifi Gunes
>            Assignee: Mehant Baid
>             Fix For: 1.5.0
> Currently queries pending in the queue are not listed in the web UI besides we use the
state PENDING to mean pending executions. This issue proposes i) to list enqueued queries
in the web UI ii) to introduce a new state for queries sitting at the queue, differentiating
then from those pending execution.

This message was sent by Atlassian JIRA

View raw message