drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3941) Add timing instrumentation around Partition Pruning
Date Tue, 03 Nov 2015 01:16:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986442#comment-14986442
] 

ASF GitHub Bot commented on DRILL-3941:
---------------------------------------

Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/230#discussion_r43706882
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/PruneScanRule.java
---
    @@ -166,16 +174,28 @@ protected void doOnMatch(RelOptRuleCall call, DrillFilterRel filterRel,
DrillPro
         }
     
         if (partitionColumnBitSet.isEmpty()) {
    -      logger.debug("No partition columns are projected from the scan..continue.");
    +      logger.info("No partition columns are projected from the scan..continue. " +
    +          "Total pruning elapsed time: {} ms", totalPruningTime.elapsed(TimeUnit.MILLISECONDS));
    --- End diff --
    
    I think this is fine, since we always print a message at the beginning of PruneScanRule,
it makes sense to print message indicating when we terminated. Also the message before ("No
partition columns...) indicates that we didn't perform actual pruning. My objective was to
capture total time spent in PruneScanRule.


> Add timing instrumentation around Partition Pruning
> ---------------------------------------------------
>
>                 Key: DRILL-3941
>                 URL: https://issues.apache.org/jira/browse/DRILL-3941
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Mehant Baid
>            Assignee: Aman Sinha
>
> We seem to spending a chunk time doing partition pruning, it would be good to log timing
information to indicate the amount of time we spend doing pruning. A little more granularity
to indicate the time taken to build the filter tree and in the interpreter would also be good.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message