drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacques Nadeau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3940) Make RecordBatch AutoCloseable
Date Wed, 11 Nov 2015 05:32:10 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999958#comment-14999958
] 

Jacques Nadeau commented on DRILL-3940:
---------------------------------------

We already have CloseableRecordBatch which serves this purpose. RecordBatch is designed to
be a more limited interface that interconnects one operator to another (and is constrained
to the portion of the interface that is focused on that). It excludes the closeable interface
because operators shouldn't be able to call close on each other. CloseableRecordBatches are
closed by the RootExec. Why would we need also need to make RecordBatch AutoCloseable?

> Make RecordBatch AutoCloseable
> ------------------------------
>
>                 Key: DRILL-3940
>                 URL: https://issues.apache.org/jira/browse/DRILL-3940
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.2.0
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> This made it easier to find RecordBatches that were not cleaned up (because the compiler
complains about AutoCloseable resources that haven't been closed).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message