drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3543) Add stats for external sort to a query profile
Date Mon, 23 Nov 2015 21:55:11 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023168#comment-15023168
] 

ASF GitHub Bot commented on DRILL-3543:
---------------------------------------

GitHub user adeneche opened a pull request:

    https://github.com/apache/drill/pull/280

    DRILL-3543: Add stats for external sort to a query profile

    added the following metrics to ExternalSortRecordBatch:
    
    metric | description
    -------- | --------------
    SPILL_COUNT | number of times operator spilled to disk
    PEAK_SIZE_IN_MEMORY | peak value for totalSizeInMemory (1)
    PEAK_BATCHES_IN_MEMORY | maximum number of batches kept in memory
    
    (1) how much memory sort estimated it's using so far. See [DRILL-4121](https://issues.apache.org/jira/browse/DRILL-4121)
for a case where this won't be enough

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adeneche/incubator-drill DRILL-3543

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
    
----
commit eb5108d529c7bdf4fb56172b64dabf9b00c815ec
Author: Hakim <hakim@adeneche.local>
Date:   2015-11-23T20:36:30Z

    DRILL-3543: Add stats for external sort to a query profile

----


> Add stats for external sort to a query profile
> ----------------------------------------------
>
>                 Key: DRILL-3543
>                 URL: https://issues.apache.org/jira/browse/DRILL-3543
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.1.0
>            Reporter: Victoria Markman
>            Assignee: Deneche A. Hakim
>            Priority: Critical
>              Labels: usability
>             Fix For: 1.4.0
>
>
> The only indication if sort spilled to disk today is info from the drillbit.log.
> It would be great if this information was displayed in the query profile.
> {code}
> 015-07-22 23:47:29,907 [2a4fd46e-f8c3-6b96-b165-b665a41be311:frag:0:0] INFO  o.a.d.e.p.i.xsort.ExternalSortBatch
- Completed spilling to /tmp/drill/spill/2a4fd46e-f8c3-6b96-b165-b665a41be311/major_fragment_0/minor_fragment_0/operator_7/92
> 2015-07-22 23:47:29,919 [2a4fd46e-f8c3-6b96-b165-b665a41be311:frag:0:0] INFO  o.a.d.e.p.i.xsort.ExternalSortBatch
- Merging and spilling to /tmp/drill/spill/2a4fd46e-f8c3-6b96-b165-b665a41be311/major_fragment_0/minor_fragment_0/operator_7/93
> 2015-07-22 23:47:29,919 [2a4fd46e-f8c3-6b96-b165-b665a41be311:frag:0:0] INFO  o.a.d.e.p.i.xsort.ExternalSortBatch
- Completed spilling to /tmp/drill/spill/2a4fd46e-f8c3-6b96-b165-b665a41be311/major_fragment_0/minor_fragment_0/operator_7/93
> 2015-07-22 23:47:29,919 [2a4fd46e-f8c3-6b96-b165-b665a41be311:frag:0:0] WARN  o.a.d.e.p.i.xsort.ExternalSortBatch
- Starting to merge. 7 batch groups. Current allocated memory: 11566787
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message