drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2618) BasicFormatMatcher calls getFirstPath(...) without checking # of paths is not zero
Date Thu, 19 Nov 2015 21:21:11 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014394#comment-15014394
] 

ASF GitHub Bot commented on DRILL-2618:
---------------------------------------

GitHub user hnfgns opened a pull request:

    https://github.com/apache/drill/pull/270

    DRILL-2618: handle queries over empty folders consistently so that th…

    …ey report table not found rather than failing.
    
    Refactor FileSelection to eliminate redundancy, make it more managable
    Fix WorkspaceSchemaFactory to handle empty folders.
    Introduce ParquetFileSelection, a sub-class of FileSelection that carries along metadata
cache
    Fix MagicStringMatcher so that it operate on files only.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hnfgns/incubator-drill DRILL-2618

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #270
    
----
commit 51de65851c5d355d88f682bc0fc9c0853f216d3c
Author: Hanifi Gunes <hanifigunes@gmail.com>
Date:   2015-11-17T02:33:13Z

    DRILL-2618: handle queries over empty folders consistently so that they report table not
found rather than failing.
    Refactor FileSelection to eliminate redundancy, make it more managable
    Fix WorkspaceSchemaFactory to handle empty folders.
    Introduce ParquetFileSelection, a sub-class of FileSelection that carries along metadata
cache
    Fix MagicStringMatcher so that it operate on files only.

----


> BasicFormatMatcher calls getFirstPath(...) without checking # of paths is not zero
> ----------------------------------------------------------------------------------
>
>                 Key: DRILL-2618
>                 URL: https://issues.apache.org/jira/browse/DRILL-2618
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Other
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Deneche A. Hakim
>             Fix For: Future
>
>
> {{BasicFormatMatcher.isReadable(...)}} calls {{getFirstPath(...)}} without checking that
there is at least one path.  This can cause an IndexOutOfBoundsException.
> To reproduce, create an empty directory {{/tmp/CaseInsensitiveColumnNames}} and run {{exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message