drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-2288) ScanBatch violates IterOutcome protocol for zero-row sources [was: missing JDBC metadata (schema) for 0-row results...]
Date Tue, 03 Nov 2015 05:23:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986712#comment-14986712
] 

ASF GitHub Bot commented on DRILL-2288:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43717182
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
    @@ -325,10 +325,13 @@ public AggOutcome doWork() {
                     if (EXTRA_DEBUG_1) {
                       logger.debug("Received new schema.  Batch has {} records.", incoming.getRecordCount());
                     }
    -                newSchema = true;
    -                this.cleanup();
    -                // TODO: new schema case needs to be handled appropriately
    -                return AggOutcome.UPDATE_AGGREGATOR;
    +                final BatchSchema newIncomingSchema = incoming.getSchema();
    +                if ((! newIncomingSchema.equals(schema)) && schema != null) {
    --- End diff --
    
    You shouldn't put a hack in to ignore a valid schema change. I don't know all the details
but if this is related to HBase, my thought is you probably need to resolve 4010 to avoid
spurious schema changes. You should make sure to avoid propagating schema changes that are
not real/required. Solving on a particular operator just means if the query plan changes,
you'll probably get an error in a different operator. 


> ScanBatch violates IterOutcome protocol for zero-row sources [was: missing JDBC metadata
(schema) for 0-row results...]
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-2288
>                 URL: https://issues.apache.org/jira/browse/DRILL-2288
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Information Schema
>            Reporter: Daniel Barclay (Drill)
>            Assignee: Daniel Barclay (Drill)
>             Fix For: 1.3.0
>
>         Attachments: Drill2288NoResultSetMetadataWhenZeroRowsTest.java
>
>
> The ResultSetMetaData object from getMetadata() of a ResultSet is not set up (getColumnCount()
returns zero, and trying to access any other metadata throws IndexOutOfBoundsException) for
a result set with zero rows, at least for one from DatabaseMetaData.getColumns(...).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message