Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B4171856E for ; Mon, 12 Oct 2015 22:32:11 +0000 (UTC) Received: (qmail 14124 invoked by uid 500); 12 Oct 2015 22:32:05 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 14095 invoked by uid 500); 12 Oct 2015 22:32:05 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 14084 invoked by uid 99); 12 Oct 2015 22:32:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 22:32:05 +0000 Date: Mon, 12 Oct 2015 22:32:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-3920) Add vector loading tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953892#comment-14953892 ] ASF GitHub Bot commented on DRILL-3920: --------------------------------------- Github user hnfgns commented on a diff in the pull request: https://github.com/apache/drill/pull/194#discussion_r41808424 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java --- @@ -355,17 +353,19 @@ public void generateTestData(int values) { } @Override public void clear() { - valueCount = 0; - for (ValueVector v : getChildren()) { + for (final ValueVector v : getChildren()) { --- End diff -- the logic in clear() seems duplicating close(). we should directly call close perhaps. > Add vector loading tests > ------------------------ > > Key: DRILL-3920 > URL: https://issues.apache.org/jira/browse/DRILL-3920 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Data Types > Affects Versions: 1.2.0 > Reporter: Chris Westin > Assignee: Chris Westin > > Add some additional tests to TestValueVector to test serialization and reloading of vectors, as well as the underlying buffer slicing operations that are used for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)