Return-Path: X-Original-To: apmail-drill-issues-archive@minotaur.apache.org Delivered-To: apmail-drill-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E46E17D5A for ; Fri, 30 Oct 2015 05:02:28 +0000 (UTC) Received: (qmail 95949 invoked by uid 500); 30 Oct 2015 05:02:28 -0000 Delivered-To: apmail-drill-issues-archive@drill.apache.org Received: (qmail 95923 invoked by uid 500); 30 Oct 2015 05:02:27 -0000 Mailing-List: contact issues-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list issues@drill.apache.org Received: (qmail 95895 invoked by uid 99); 30 Oct 2015 05:02:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Oct 2015 05:02:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id B3E652C14E1 for ; Fri, 30 Oct 2015 05:02:27 +0000 (UTC) Date: Fri, 30 Oct 2015 05:02:27 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@drill.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DRILL-3232) Modify existing vectors to allow type promotion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981896#comment-14981896 ] ASF GitHub Bot commented on DRILL-3232: --------------------------------------- Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/207#discussion_r43471990 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/GetSetVectorHelper.java --- @@ -114,6 +115,9 @@ public static JInvocation write(MajorType type, JVar vector, HoldingContainer in JInvocation setMethod = vector.invoke("getMutator").invoke(setMethodName).arg(indexVariable); + if (type.getMinorType() == MinorType.UNION) { --- End diff -- Why isn't this part of the lower case statement? > Modify existing vectors to allow type promotion > ----------------------------------------------- > > Key: DRILL-3232 > URL: https://issues.apache.org/jira/browse/DRILL-3232 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Codegen, Execution - Data Types, Execution - Relational Operators, Functions - Drill > Reporter: Steven Phillips > Assignee: Hanifi Gunes > Fix For: 1.3.0 > > > Support the ability for existing vectors to be promoted similar to supported implicit casting rules. > For example: > INT > DOUBLE > STRING > EMBEDDED -- This message was sent by Atlassian JIRA (v6.3.4#6332)