drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3930) Remove direct references to TopLevelAllocator from unit tests
Date Tue, 13 Oct 2015 21:57:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955772#comment-14955772
] 

ASF GitHub Bot commented on DRILL-3930:
---------------------------------------

GitHub user cwestin opened a pull request:

    https://github.com/apache/drill/pull/200

    DRILL-3930: Remove direct references to TopLevelAllocator from unit t…

    …ests
    
    Ensure RootAllocatorFactory is used throughout the code so
    that we can change allocators via configuration or software. Use
    DrillAutoCloseables to handle exceptions that could happen from some
    allocator close() calls when the allocator is in an improper state.
    
    Unit tests pass
    Regression suite passes, except for
    - a couple of the known "Selected column 'dir0' must have name 'columns' or must be plain
'*'"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cwestin/incubator-drill DRILL-3930

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #200
    
----
commit 5f390ad35eec9147bfaca1763b94f2cbf1d55821
Author: Chris Westin <cwestin@yahoo.com>
Date:   2015-10-13T20:49:57Z

    DRILL-3930: Remove direct references to TopLevelAllocator from unit tests
    Ensure RootAllocatorFactory is used throughout the code so
    that we can change allocators via configuration or software. Use
    DrillAutoCloseables to handle exceptions that could happen from some
    allocator close() calls when the allocator is in an improper state.

----


> Remove direct references to TopLevelAllocator from unit tests
> -------------------------------------------------------------
>
>                 Key: DRILL-3930
>                 URL: https://issues.apache.org/jira/browse/DRILL-3930
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>    Affects Versions: 1.2.0
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> The RootAllocatorFactory should be used throughout the code to allow us to change allocators
via configuration or other software choices. Some unit tests still reference TopLevelAllocator
directly. We also need to do a better job of handling exceptions that can be handled by close()ing
an allocator that isn't in the proper state (remaining open child allocators, outstanding
buffers, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message