drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3927) Use OutOfMemoryException in more places
Date Wed, 14 Oct 2015 18:05:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957406#comment-14957406
] 

ASF GitHub Bot commented on DRILL-3927:
---------------------------------------

Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/199#discussion_r42029468
  
    --- Diff: common/src/main/java/org/apache/drill/common/DeferredException.java ---
    @@ -47,6 +75,15 @@ public void addException(final Exception exception) {
           Preconditions.checkState(!isClosed);
     
           if (this.exception == null) {
    +        if (exceptionSupplier == null) {
    +          this.exception = exception;
    +        } else {
    +          this.exception = exceptionSupplier.get();
    +          if (this.exception == null) {
    +            this.exception = new RuntimeException("Missing root exception");
    +          }
    +          this.exception.addSuppressed(exception);
    +        }
             this.exception = exception;
    --- End diff --
    
    Yes, that would be a bug. Done.


> Use OutOfMemoryException in more places
> ---------------------------------------
>
>                 Key: DRILL-3927
>                 URL: https://issues.apache.org/jira/browse/DRILL-3927
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> The new allocator uses OutOfMemoryException in better ways; some additional exception
handling sites need to catch and handle this exception in preparation for the new allocator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message