drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3927) Use OutOfMemoryException in more places
Date Wed, 14 Oct 2015 17:09:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957291#comment-14957291
] 

ASF GitHub Bot commented on DRILL-3927:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/199#discussion_r42022118
  
    --- Diff: common/src/main/java/org/apache/drill/common/DrillAutoCloseables.java ---
    @@ -0,0 +1,50 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.common;
    +
    +/**
    + * Provides functionality comparable to Guava's Closeables for AutoCloseables.
    + */
    +public class DrillAutoCloseables {
    +  /**
    +   * Constructor. Prevents construction for class of static utilities.
    +   */
    +  private DrillAutoCloseables() {
    +  }
    +
    +  /**
    +   * close() an {@see java.lang.AutoCloseable} without throwing a (checked)
    +   * {@see java.lang.Exception}. This wraps the close() call with a
    +   * try-catch that will rethrow an Exception wrapped with a
    +   * {@see java.lang.RuntimeException}, providing a way to call close()
    +   * without having to do the try-catch everywhere or propagate the Exception.
    +   *
    +   * @param closeable the AutoCloseable to close; may be null
    +   * @throws RuntimeException if an Exception occurs; the Exception is
    +   *   wrapped by the RuntimeException
    +   */
    +  public static void closeNoChecked(final AutoCloseable autoCloseable) {
    --- End diff --
    
    can't we just add this to org.apache.drill.common.AutoCloseables ? it seems to serve the
same purpose


> Use OutOfMemoryException in more places
> ---------------------------------------
>
>                 Key: DRILL-3927
>                 URL: https://issues.apache.org/jira/browse/DRILL-3927
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> The new allocator uses OutOfMemoryException in better ways; some additional exception
handling sites need to catch and handle this exception in preparation for the new allocator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message