drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3927) Use OutOfMemoryException in more places
Date Wed, 14 Oct 2015 17:08:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957290#comment-14957290
] 

ASF GitHub Bot commented on DRILL-3927:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/199#discussion_r42021960
  
    --- Diff: common/src/main/java/org/apache/drill/common/DeferredException.java ---
    @@ -123,6 +160,9 @@ public void suppressingClose(final AutoCloseable autoCloseable) {
             autoCloseable.close();
           } catch(final Exception e) {
             addException(e);
    +      } catch(final Error e) {
    +        logger.warn("caught Error {}", e);
    --- End diff --
    
    why log the error here ? we have a JIRA to try and do reduce error logging to the minimum
[DRILL-2692](https://issues.apache.org/jira/browse/DRILL-2692)


> Use OutOfMemoryException in more places
> ---------------------------------------
>
>                 Key: DRILL-3927
>                 URL: https://issues.apache.org/jira/browse/DRILL-3927
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Flow
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> The new allocator uses OutOfMemoryException in better ways; some additional exception
handling sites need to catch and handle this exception in preparation for the new allocator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message