drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3920) Add vector loading tests
Date Tue, 13 Oct 2015 18:48:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955452#comment-14955452
] 

ASF GitHub Bot commented on DRILL-3920:
---------------------------------------

Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/194#discussion_r41907790
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
---
    @@ -355,17 +353,19 @@ public void generateTestData(int values) { }
     
       @Override
       public void clear() {
    -    valueCount = 0;
    -    for (ValueVector v : getChildren()) {
    +    for (final ValueVector v : getChildren()) {
    --- End diff --
    
    But clear() doesn't call vectors.clear(). I seem to recall a problem with adding that
to clear() in the past. I'm worried this will introduce a regression, so I'd rather not take
that change on now.


> Add vector loading tests
> ------------------------
>
>                 Key: DRILL-3920
>                 URL: https://issues.apache.org/jira/browse/DRILL-3920
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Data Types
>    Affects Versions: 1.2.0
>            Reporter: Chris Westin
>            Assignee: Chris Westin
>
> Add some additional tests to TestValueVector to test serialization and reloading of vectors,
as well as the underlying buffer slicing operations that are used for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message