drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3742) Improve classpath scanning to reduce the time it takes
Date Thu, 15 Oct 2015 06:38:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958413#comment-14958413
] 

ASF GitHub Bot commented on DRILL-3742:
---------------------------------------

Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r42087783
  
    --- Diff: contrib/storage-hive/core/pom.xml ---
    @@ -114,36 +114,17 @@
                 <version>2.3.19</version>
               </dependency>
             </dependencies>
    -        <configuration>
    -          <cfgFile>src/main/codegen/config.fmpp</cfgFile>
    -          <outputDirectory>target/generated-sources</outputDirectory>
    -          <templateDirectory>src/main/codegen/templates</templateDirectory>
    -        </configuration>
             <executions>
               <execution>
                 <id>generate-fmpp-sources</id>
    -            <phase>initialize</phase>
    +            <phase>generate-sources</phase>
                 <goals>
                   <goal>generate</goal>
                 </goals>
    -          </execution>
    -        </executions>
    -      </plugin>
    -      <plugin>
    -        <groupId>org.codehaus.mojo</groupId>
    -        <artifactId>build-helper-maven-plugin</artifactId>
    -        <version>1.5</version>
    -        <executions>
    -          <execution>
    -            <id>add-fmpp-sources</id>
    -            <phase>validate</phase>
    -            <goals>
    -              <goal>add-source</goal>
    -            </goals>
                 <configuration>
    -              <sources>
    -                <source>${project.build.directory}/generated-sources</source>
    -              </sources>
    +              <config>src/main/codegen/config.fmpp</config>
    +              <output>target/generated-sources</output>
    --- End diff --
    
    s/target/${build root}


> Improve classpath scanning to reduce the time it takes
> ------------------------------------------------------
>
>                 Key: DRILL-3742
>                 URL: https://issues.apache.org/jira/browse/DRILL-3742
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Julien Le Dem
>             Fix For: Future
>
>
> classpath scanning and function registry take a long time (seconds every time).
> We'd want to avoid loading the classes (use bytecode inspection instead) and have a build
time cache to avoid doing the scanning at startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message