drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3742) Improve classpath scanning to reduce the time it takes
Date Tue, 13 Oct 2015 23:28:05 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955923#comment-14955923
] 

ASF GitHub Bot commented on DRILL-3742:
---------------------------------------

Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r41939768
  
    --- Diff: common/src/main/java/org/apache/drill/common/scanner/persistence/ScanResult.java
---
    @@ -0,0 +1,164 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.common.scanner.persistence;
    +
    +import static com.google.common.base.Preconditions.checkNotNull;
    +import static java.lang.String.format;
    +import static java.util.Arrays.asList;
    +import static java.util.concurrent.TimeUnit.MILLISECONDS;
    +
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.HashMap;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.Set;
    +
    +import org.apache.drill.common.exceptions.DrillRuntimeException;
    +import org.apache.drill.common.scanner.ClassPathScanner;
    +
    +import com.fasterxml.jackson.annotation.JsonCreator;
    +import com.fasterxml.jackson.annotation.JsonProperty;
    +import com.google.common.base.Stopwatch;
    +import com.google.common.collect.HashMultimap;
    +import com.google.common.collect.Multimap;
    +
    +/**
    + * The root doc of the scan result
    + */
    +public final class ScanResult {
    +  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(ScanResult.class);
    +  private final List<String> prescannedPackages;
    +  private final List<String> scannedPackages;
    +  private final List<FunctionDescriptor> functions;
    +  private final List<ParentClassDescriptor> implementations;
    +  private final Map<String, ParentClassDescriptor> parentClassByName;
    +
    +  @JsonCreator public ScanResult(
    +      @JsonProperty("prescannedPackages") List<String> prescannedPackages,
    +      @JsonProperty("scannedPackages") List<String> scannedPackages,
    +      @JsonProperty("functions") List<FunctionDescriptor> functions,
    --- End diff --
    
    In that case we extract also the fields and the annotations which we don't do for just
impl scanning.
    I changed that a little bit.


> Improve classpath scanning to reduce the time it takes
> ------------------------------------------------------
>
>                 Key: DRILL-3742
>                 URL: https://issues.apache.org/jira/browse/DRILL-3742
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Julien Le Dem
>             Fix For: Future
>
>
> classpath scanning and function registry take a long time (seconds every time).
> We'd want to avoid loading the classes (use bytecode inspection instead) and have a build
time cache to avoid doing the scanning at startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message