drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3340) Add named metrics and named operators in OperatorProfile
Date Fri, 23 Oct 2015 16:37:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971324#comment-14971324
] 

ASF GitHub Bot commented on DRILL-3340:
---------------------------------------

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/216#discussion_r42885902
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorMetricRegistry.java
---
    @@ -0,0 +1,75 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.ops;
    +
    +import org.apache.drill.exec.physical.impl.ScreenCreator;
    +import org.apache.drill.exec.physical.impl.SingleSenderCreator;
    +import org.apache.drill.exec.physical.impl.aggregate.HashAggTemplate;
    +import org.apache.drill.exec.physical.impl.broadcastsender.BroadcastSenderRootExec;
    +import org.apache.drill.exec.physical.impl.join.HashJoinBatch;
    +import org.apache.drill.exec.physical.impl.mergereceiver.MergingRecordBatch;
    +import org.apache.drill.exec.physical.impl.partitionsender.PartitionSenderRootExec;
    +import org.apache.drill.exec.physical.impl.unorderedreceiver.UnorderedReceiverBatch;
    +import org.apache.drill.exec.proto.UserBitShared.CoreOperatorType;
    +
    +/**
    + * Registry of operator metrics.
    + */
    +public class OperatorMetricRegistry {
    +//  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(OperatorToMetricsMapping.class);
    --- End diff --
    
    can you change the class passed to `getLogger()` from `OperatorToMetricsMapping` to `OperatorMetricRegistry`
?


> Add named metrics and named operators in OperatorProfile
> --------------------------------------------------------
>
>                 Key: DRILL-3340
>                 URL: https://issues.apache.org/jira/browse/DRILL-3340
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Sudheesh Katkam
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.3.0
>
>         Attachments: DRILL-3340.1.patch.txt, DRILL-3340.2.patch.txt, DRILL-3340.3.patch.txt
>
>
> + Useful when reading JSON query profile.
> + Rename FragmentStats#getOperatorStats to FragmentStats#newOperatorStats



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message