drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3300) Parameter never used in HBaseGroupScan
Date Thu, 01 Oct 2015 22:33:26 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940544#comment-14940544
] 

ASF GitHub Bot commented on DRILL-3300:
---------------------------------------

GitHub user aleph-zero opened a pull request:

    https://github.com/apache/drill/pull/183

    [DRILL-3300] Bug fix: Unused method parameter

    Fixed a bug whereby HBaseGroupScan.setFilterPushedDown(boolean) was not using the value
    passed to it to set an internal flag. Instead the method was always
    setting the value to 'true'.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aleph-zero/drill issues/DRILL-3300

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit 1089cf6e8543ad1659c350123a77599594cae108
Author: aleph-zero <andrew@primer.org>
Date:   2015-10-01T22:30:24Z

    [DRILL-3300] Bug fix: Unused method parameter
    
    Fixed a bug whereby setFilterPushedDown(boolean) was not using the value
    passed to it to set an internal flag. Instead the method was always
    setting the value to 'true'.

----


> Parameter never used in HBaseGroupScan
> --------------------------------------
>
>                 Key: DRILL-3300
>                 URL: https://issues.apache.org/jira/browse/DRILL-3300
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - HBase
>    Affects Versions: 1.0.0
>            Reporter: Andrew
>            Assignee: Andrew
>            Priority: Trivial
>             Fix For: Future
>
>
> The method HBaseGroupScan.setFilterPushedDown(boolean) does not read it's parameter value:
>   public void setFilterPushedDown(boolean b) {
>     this.filterPushedDown = true;
>   }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message