drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3232) Modify existing vectors to allow type promotion
Date Fri, 30 Oct 2015 05:09:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981903#comment-14981903
] 

ASF GitHub Bot commented on DRILL-3232:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43472231
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/UnionFunctions.java
---
    @@ -0,0 +1,184 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.fn.impl;
    +
    +import io.netty.buffer.DrillBuf;
    +import org.apache.drill.common.types.TypeProtos.MinorType;
    +import org.apache.drill.exec.expr.DrillSimpleFunc;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate.NullHandling;
    +import org.apache.drill.exec.expr.annotations.Output;
    +import org.apache.drill.exec.expr.annotations.Param;
    +import org.apache.drill.exec.expr.holders.BigIntHolder;
    +import org.apache.drill.exec.expr.holders.BitHolder;
    +import org.apache.drill.exec.expr.holders.NullableIntHolder;
    +import org.apache.drill.exec.expr.holders.NullableUInt1Holder;
    +import org.apache.drill.exec.expr.holders.UnionHolder;
    +import org.apache.drill.exec.expr.holders.IntHolder;
    +import org.apache.drill.exec.expr.holders.VarCharHolder;
    +import org.apache.drill.exec.vector.complex.impl.UnionReader;
    +import org.apache.drill.exec.vector.complex.reader.FieldReader;
    +
    +import javax.inject.Inject;
    +
    +public class UnionFunctions {
    +
    +  @FunctionTemplate(names = {"typeOf"},
    +          scope = FunctionTemplate.FunctionScope.SIMPLE,
    +          nulls = NullHandling.INTERNAL)
    +  public static class GetType implements DrillSimpleFunc {
    +
    +    @Param
    +    FieldReader input;
    +    @Output
    +    VarCharHolder out;
    +    @Inject
    +    DrillBuf buf;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +
    +      byte[] type;
    +      if (input.isSet()) {
    +         type = input.getType().getMinorType().name().getBytes();
    +      } else {
    +        type = org.apache.drill.common.types.TypeProtos.MinorType.NULL.name().getBytes();
    +      }
    +      buf = buf.reallocIfNeeded(type.length);
    +      buf.setBytes(0, type);
    +      out.buffer = buf;
    +      out.start = 0;
    +      out.end = type.length;
    +    }
    +  }
    +
    +  @SuppressWarnings("unused")
    +  @FunctionTemplate(names = {"castUNION", "castToUnion"}, scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls=NullHandling.NULL_IF_NULL)
    +  public static class CastUnionToUnion implements DrillSimpleFunc{
    +
    +    @Param FieldReader in;
    +    @Output
    +    UnionHolder out;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +      out.reader = in;
    +      out.isSet = in.isSet() ? 1 : 0;
    +    }
    +  }
    +
    +  @SuppressWarnings("unused")
    +  @FunctionTemplate(name = "asList", scope = FunctionTemplate.FunctionScope.SIMPLE, nulls=NullHandling.INTERNAL)
    +  public static class CastUnionList implements DrillSimpleFunc {
    +
    +    @Param UnionHolder in;
    +    @Output UnionHolder out;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +      if (in.isSet == 1) {
    +        out.reader = in.reader;
    +      } else {
    +        out.isSet = 0;
    +      }
    +    }
    +  }
    +
    +  @SuppressWarnings("unused")
    +  @FunctionTemplate(name = "is_LIST", scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls=NullHandling.INTERNAL)
    +  public static class UnionIsList implements DrillSimpleFunc {
    +
    +    @Param UnionHolder in;
    +    @Output BitHolder out;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +      if (in.isSet == 1) {
    +        out.value = in.getType().getMinorType() == org.apache.drill.common.types.TypeProtos.MinorType.LIST
? 1 : 0;
    +      } else {
    +        out.value = 0;
    +      }
    +    }
    +  }
    +
    +  @SuppressWarnings("unused")
    +  @FunctionTemplate(name = "asMap", scope = FunctionTemplate.FunctionScope.SIMPLE, nulls=NullHandling.INTERNAL)
    +  public static class CastUnionMap implements DrillSimpleFunc {
    +
    +    @Param UnionHolder in;
    +    @Output UnionHolder out;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +      if (in.isSet == 1) {
    +        out.reader = in.reader;
    --- End diff --
    
    This seems like it should do checking rather than just convert. Also, shouldn't this be
assert_map to be consistent with other functions?


> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
>                 Key: DRILL-3232
>                 URL: https://issues.apache.org/jira/browse/DRILL-3232
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Codegen, Execution - Data Types, Execution - Relational
Operators, Functions - Drill
>            Reporter: Steven Phillips
>            Assignee: Hanifi Gunes
>             Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported implicit
casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message