drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3232) Modify existing vectors to allow type promotion
Date Fri, 30 Oct 2015 05:06:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981899#comment-14981899
] 

ASF GitHub Bot commented on DRILL-3232:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43472119
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionGenerationHelper.java
---
    @@ -127,7 +133,7 @@ protected static boolean isComparableType(MajorType type) {
     
       private static String formatCanNotCompareMsg(MajorType left, MajorType right) {
         StringBuilder sb = new StringBuilder();
    -    sb.append("Map, Array or repeated scalar type should not be used in group by, order
by or in a comparison operator. Drill does not support compare between ");
    +    sb.append("Map, Array, Union or repeated scalar type should not be used in group
by, order by or in a comparison operator. Drill does not support compare between ");
    --- End diff --
    
    Union here seems like a problem. The two values could very much be comparable. Shouldn't
this just be a reasonably large case statement?


> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
>                 Key: DRILL-3232
>                 URL: https://issues.apache.org/jira/browse/DRILL-3232
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Codegen, Execution - Data Types, Execution - Relational
Operators, Functions - Drill
>            Reporter: Steven Phillips
>            Assignee: Hanifi Gunes
>             Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported implicit
casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message