drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3232) Modify existing vectors to allow type promotion
Date Fri, 30 Oct 2015 04:35:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981863#comment-14981863
] 

ASF GitHub Bot commented on DRILL-3232:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43471193
  
    --- Diff: exec/java-exec/src/main/codegen/templates/UnionFunctions.java ---
    @@ -0,0 +1,121 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +<@pp.dropOutputFile />
    +<@pp.changeOutputFile name="/org/apache/drill/exec/expr/fn/impl/GUnionFunctions.java"
/>
    +
    +
    +<#include "/@includes/license.ftl" />
    +
    +package org.apache.drill.exec.expr.fn.impl;
    +
    +<#include "/@includes/vv_imports.ftl" />
    +import org.apache.drill.exec.expr.DrillSimpleFunc;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate;
    +import org.apache.drill.exec.expr.annotations.FunctionTemplate.NullHandling;
    +import org.apache.drill.exec.expr.annotations.Output;
    +import org.apache.drill.exec.expr.annotations.Param;
    +import org.apache.drill.exec.expr.holders.*;
    +import javax.inject.Inject;
    +import io.netty.buffer.DrillBuf;
    +import org.apache.drill.exec.record.RecordBatch;
    +
    +/*
    + * This class is generated using freemarker and the ${.template_name} template.
    + */
    +
    +@SuppressWarnings("unused")
    +public class GUnionFunctions {
    +
    +  <#list vv.types as type><#list type.minor as minor><#assign name = minor.class?cap_first
/>
    +  <#assign fields = minor.fields!type.fields />
    +  <#assign uncappedName = name?uncap_first/>
    +
    +  <#if !minor.class?starts_with("Decimal")>
    +
    +  @SuppressWarnings("unused")
    +  @FunctionTemplate(name = "is_${name?upper_case}", scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls=NullHandling.INTERNAL)
    +  public static class UnionIs${name} implements DrillSimpleFunc {
    +
    +    @Param UnionHolder in;
    +    @Output BitHolder out;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +      if (in.isSet == 1) {
    +        out.value = in.getType().getMinorType() == org.apache.drill.common.types.TypeProtos.MinorType.${name?upper_case}
? 1 : 0;
    +      } else {
    +        out.value = 0;
    +      }
    +    }
    +  }
    +
    +  @SuppressWarnings("unused")
    +  @FunctionTemplate(name = "assert_${name?upper_case}", scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls=NullHandling.INTERNAL)
    +  public static class CastUnion${name} implements DrillSimpleFunc {
    +
    +    @Param UnionHolder in;
    +    @Output Nullable${name}Holder out;
    +
    +    public void setup() {}
    +
    +    public void eval() {
    +      if (in.isSet == 1) {
    +        in.reader.read(out);
    --- End diff --
    
    What happens if the reader doesn't support that type. Do we get an error? If so, is that
a nice exception?


> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
>                 Key: DRILL-3232
>                 URL: https://issues.apache.org/jira/browse/DRILL-3232
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Codegen, Execution - Data Types, Execution - Relational
Operators, Functions - Drill
>            Reporter: Steven Phillips
>            Assignee: Hanifi Gunes
>             Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported implicit
casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message