drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-3232) Modify existing vectors to allow type promotion
Date Fri, 30 Oct 2015 04:30:27 GMT

    [ https://issues.apache.org/jira/browse/DRILL-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981850#comment-14981850
] 

ASF GitHub Bot commented on DRILL-3232:
---------------------------------------

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43471006
  
    --- Diff: exec/java-exec/src/main/codegen/templates/MapWriters.java ---
    @@ -70,10 +79,15 @@ public MaterializedField getField() {
       @Override
       public MapWriter map(String name) {
           FieldWriter writer = fields.get(name.toLowerCase());
    -    if(writer == null) {
    -      int vectorCount = container.size();
    -      MapVector vector = container.addOrGet(name, MapVector.TYPE, MapVector.class);
    -      writer = new SingleMapWriter(vector, this);
    +    if(writer == null){
    +      int vectorCount=container.size();
    +      if(!unionEnabled || unionInternalMap){
    +        MapVector vector=container.addOrGet(name,MapVector.TYPE,MapVector.class);
    --- End diff --
    
    let's pull out the common expression between these two cases


> Modify existing vectors to allow type promotion
> -----------------------------------------------
>
>                 Key: DRILL-3232
>                 URL: https://issues.apache.org/jira/browse/DRILL-3232
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Execution - Codegen, Execution - Data Types, Execution - Relational
Operators, Functions - Drill
>            Reporter: Steven Phillips
>            Assignee: Hanifi Gunes
>             Fix For: 1.3.0
>
>
> Support the ability for existing vectors to be promoted similar to supported implicit
casting rules.
> For example:
> INT > DOUBLE > STRING > EMBEDDED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message