drill-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DRILL-1065) Provide a reset command to reset an option to its default value
Date Thu, 01 Oct 2015 05:49:04 GMT

    [ https://issues.apache.org/jira/browse/DRILL-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939352#comment-14939352

ASF GitHub Bot commented on DRILL-1065:

Github user jacques-n commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/FallbackOptionManager.java
    @@ -102,6 +125,29 @@ public void setOption(OptionValue value) {
    +  public void deleteOption(final String name, final OptionType type) {
    +    try {
    +      SystemOptionManager.getValidator(name); // ensure the option exists
    +    } catch (final IllegalArgumentException e) {
    +      throw UserException.validationError(e)
    +        .build(logger);
    --- End diff --
    My main issue here is that we have an unfriendly message. One of the things that we should
be doing is creating a user friendly message at the point of user exception creation. If you
think it was too deep one level deeper, then you should make a friendly user message at this
level. Trusting that the system level exception message is meaningful to the user should be

> Provide a reset command to reset an option to its default value
> ---------------------------------------------------------------
>                 Key: DRILL-1065
>                 URL: https://issues.apache.org/jira/browse/DRILL-1065
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Flow
>            Reporter: Aman Sinha
>            Assignee: Sudheesh Katkam
>            Priority: Minor
>             Fix For: 1.2.0
> Within a session, currently we set configuration options and it would be very useful
to have a 'reset' command to reset the value of an option to its default system value: 
>   ALTER SESSION RESET <option name> 
> If we don't want to add a new keyword for RESET, we could potentially overload the SET
command and allow the user to set to the 'default' value.

This message was sent by Atlassian JIRA

View raw message