Return-Path: 
 <issues-return-24181-apmail-drill-issues-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-issues-archive@minotaur.apache.org
Delivered-To: apmail-drill-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 090B5181BA
	for <apmail-drill-issues-archive@minotaur.apache.org>;
 Tue, 29 Sep 2015 22:57:08 +0000 (UTC)
Received: (qmail 84211 invoked by uid 500); 29 Sep 2015 22:57:05 -0000
Delivered-To: apmail-drill-issues-archive@drill.apache.org
Received: (qmail 84150 invoked by uid 500); 29 Sep 2015 22:57:04 -0000
Mailing-List: contact issues-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@drill.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@drill.apache.org>
List-Post: <mailto:issues@drill.apache.org>
List-Id: <issues.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list issues@drill.apache.org
Received: (qmail 84140 invoked by uid 99); 29 Sep 2015 22:57:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2015 22:57:04 +0000
Date: Tue, 29 Sep 2015 22:57:04 +0000 (UTC)
From: "Daniel Barclay (Drill) (JIRA)" <jira@apache.org>
To: issues@drill.apache.org
Message-ID: <JIRA.12901449.1443564352000.107752.1443567424828@Atlassian.JIRA>
In-Reply-To: <JIRA.12901449.1443564352000@Atlassian.JIRA>
References: <JIRA.12901449.1443564352000@Atlassian.JIRA>
 <JIRA.12901449.1443564352800@arcas>
Subject: [jira] [Comment Edited] (DRILL-3861) Apparent uncontrolled format
 string error in table name error reporting
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DRILL-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936057#comment-14936057 ] 

Daniel Barclay (Drill) edited comment on DRILL-3861 at 9/29/15 10:56 PM:
-------------------------------------------------------------------------

This error feels like the same flavor of format-string error, but it has {#\} instead of {%\}:


{noformat}
0: jdbc:drill:zk=local> select * from `dfs.tmp`.`file:test#numbersign.json`;
Error: SYSTEM ERROR: IllegalFormatWidthException: 23


[Error Id: 056a4667-7d97-420a-9072-17c9d1c660c7 on dev-linux2:31010] (state=,code=0)
0: jdbc:drill:zk=local> 
{noformat}



was (Author: dsbos):
This error feels like the same flavor of format-string error, but it has {#\} instead of {\%}:


{noformat}
0: jdbc:drill:zk=local> select * from `dfs.tmp`.`file:test#numbersign.json`;
Error: SYSTEM ERROR: IllegalFormatWidthException: 23


[Error Id: 056a4667-7d97-420a-9072-17c9d1c660c7 on dev-linux2:31010] (state=,code=0)
0: jdbc:drill:zk=local> 
{noformat}


> Apparent uncontrolled format string error in table name error reporting
> -----------------------------------------------------------------------
>
>                 Key: DRILL-3861
>                 URL: https://issues.apache.org/jira/browse/DRILL-3861
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: SQL Parser
>            Reporter: Daniel Barclay (Drill)
>
> It seems that a data string is being used as a printf format string.
> In the following, note the percent character in name of the table file (which does not exist, apparently trying to cause an expected no-such-table error) and that the actual error mentions format conversion characters:
> {noformat}
> 0: jdbc:drill:zk=local> select * from `test%percent.json`;
> Sep 29, 2015 2:59:37 PM org.apache.calcite.sql.validate.SqlValidatorException <init>
> SEVERE: org.apache.calcite.sql.validate.SqlValidatorException: Table 'test%percent.json' not found
> Sep 29, 2015 2:59:37 PM org.apache.calcite.runtime.CalciteException <init>
> SEVERE: org.apache.calcite.runtime.CalciteContextException: From line 1, column 15 to line 1, column 33: Table 'test%percent.json' not found
> Error: SYSTEM ERROR: UnknownFormatConversionException: Conversion = 'p'
> [Error Id: 8025e561-6ba1-4045-bbaa-a96cafc7f719 on dev-linux2:31010] (state=,code=0)
> 0: jdbc:drill:zk=local> 
> {noformat}
> (Selecting SQL Parser component because I _think_ table/file existing is checked in validation called in or near the parsing step.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)